r/aws_datasync_agent: remove ExactlyOneOf activation_key, ip_address #35150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requirement previously prevented successful import of agents initialized with an activation_key. The `activation_key` is not returned by the read operation, so setting this required value in configuration always forced a new resource on the next apply. Practitioners could work around the issue with an `ignore_changes` `lifecycle` argument, but removing the `ExactlyOneOf` condition in favor of a `ConflictsWith` condition allows agents created with an activation key to be imported _without_ requiring the attribute to be set in the corresponding Terraform configuration.
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XS
terraform-aws-provider
bot
added
the
prioritized
|
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This requirement previously prevented successful import of agents initialized with an
activation_key. Theactivation_keyis not returned by the read operation, so setting this required value in configuration always forced a new resource on the next apply. Practitioners could work around the issue with anignore_changeslifecycle argument, but removing theExactlyOneOfcondition in favor of aConflictsWithcondition allows agents created with an activation key to be imported without requiring the attribute to be set in the corresponding Terraform configuration.An import statement can now look like:
To replace the removed functionality, an apply-time check has been added to the create operation which verifies at least one of
ip_addressoractivation_keyis set. The downside is this requirement won't be checked at plan time as before, but moving the logic here enables import to behave as expected.Relations
Closes #33458
References
Output from Acceptance Testing